Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/vm_service/test/get_allocation_traces_test is flaky #54487

Open
dcharkes opened this issue Jan 2, 2024 · 3 comments
Open

pkg/vm_service/test/get_allocation_traces_test is flaky #54487

dcharkes opened this issue Jan 2, 2024 · 3 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening vm-service The VM Service Protocol, both the specification and its implementation

Comments

@dcharkes
Copy link
Contributor

dcharkes commented Jan 2, 2024

The tests

pkg/vm_service/test/get_allocation_traces_test RuntimeError (expected Pass)

are failing on configurations

vm-linux-debug-ia32

And it's also flaky in release mode.

https://dart-current-results.web.app/#/filter=pkg/vm_service/test/get_allocation_traces_test&showAll

--- Command "vm" (took 01:41.000586s):
DART_CONFIGURATION=DebugIA32 out/DebugIA32/dart --sound-null-safety -Dtest_runner.configuration=vm-linux-debug-ia32 --ignore-unrecognized-flags --packages=/b/s/w/ir/.dart_tool/package_config.json /b/s/w/ir/pkg/vm_service/test/get_allocation_traces_test.dart

exit code:
255

stdout:
00:00 �[32m+0�[0m: get_allocation_traces_test.dart�[0m

** Launching SERVICE_TEST_TESTEE=true out/DebugIA32/dart --disable-service-auth-codes --profiler --sound-null-safety -Dtest_runner.configuration=vm-linux-debug-ia32 --ignore-unrecognized-flags --packages=/b/s/w/ir/.dart_tool/package_config.json --enable-vm-service:0 /b/s/w/ir/pkg/vm_service/test/get_allocation_traces_test.dart

>testee>out> The Dart VM service is listening on http://127.0.0.1:40519/
>testee>out> The Dart DevTools debugger and profiler is available at: http://127.0.0.1:40519/devtools?uri=ws://127.0.0.1:40519/ws
** Signaled to run test queries on http://127.0.0.1:40519/

>testee>out> 
Done loading VM

get_allocation_traces_test.dart [1/11]

get_allocation_traces_test.dart [2/11]

Checking we are at line 27

Program is stopped at line: 27

get_allocation_traces_test.dart [3/11]

get_allocation_traces_test.dart [4/11]

>testee>out> Foo
>testee>out> Bar
get_allocation_traces_test.dart [5/11]

get_allocation_traces_test.dart [6/11]

Checking we are at line 34

Program is stopped at line: 34

get_allocation_traces_test.dart [7/11]

[[CpuSample tid: 109518, timestamp: 41187719687, stack: [342, 331, 292, 285, 278, 270]]]

Allocation tracing enabled for Bar

get_allocation_traces_test.dart [8/11]

>testee>out> Bar
get_allocation_traces_test.dart [9/11]

get_allocation_traces_test.dart [10/11]

Checking we are at line 37

Program is stopped at line: 37

get_allocation_traces_test.dart [11/11]

Foo ID: classes/1192

Bar ID: classes/1193

Sample for CID: 1193

0: file:///b/s/w/ir/pkg/vm_service/test/get_allocation_traces_test.dart:25

1: file:///b/s/w/ir/pkg/vm_service/test/common/test_helper.dart:50

2: file:///b/s/w/ir/pkg/vm_service/test/common/test_helper.dart:392

3: file:///b/s/w/ir/pkg/vm_service/test/get_allocation_traces_test.dart:142

4: dart:isolate-patch/isolate_patch.dart:289

5: dart:isolate-patch/isolate_patch.dart:175

00:59 �[32m+0�[0m�[31m -1�[0m: get_allocation_traces_test.dart �[1m�[31m[E]�[0m�[0m

  Expected: <2>
    Actual: <1>
  

  package:matcher/src/expect/expect.dart 149:31              fail
  package:matcher/src/expect/expect.dart 144:3               _expect
  package:matcher/src/expect/expect.dart 56:3                expect
  pkg/vm_service/test/get_allocation_traces_test.dart 138:5  tests.<fn>
  ===== asynchronous gap ===========================
  pkg/vm_service/test/common/test_helper.dart 331:13         _ServiceTesterRunner.run.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 215:9           Declarer.test.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 213:7           Declarer.test.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/invoker.dart 258:9            Invoker._waitForOutstandingCallbacks.<fn>
  

All service tests completed successfully.

** Killing script

00:59 �[32m+0�[0m�[31m -1�[0m: �[31mSome tests failed.�[0m



Consider enabling the flag chain-stack-traces to receive more detailed exceptions.
For example, 'dart test --chain-stack-traces'.

stderr:
Unhandled exception:
Dummy exception to set exit code.

--- Re-run this test:
python3 tools/test.py -n vm-linux-debug-ia32 pkg/vm_service/test/get_allocation_traces_test
@dcharkes dcharkes added gardening vm-service The VM Service Protocol, both the specification and its implementation labels Jan 2, 2024
@bkonyi
Copy link
Contributor

bkonyi commented Jan 2, 2024

This is a tricky one, I'm unable to reproduce in release or debug mode when running against an IA32 build on Linux, even under load.

@mit-mit mit-mit added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Jan 3, 2024
@bkonyi
Copy link
Contributor

bkonyi commented Jan 3, 2024

Left this running overnight to try and catch a failure with no luck.

@bkonyi bkonyi changed the title pkg/vm_service/test/get_allocation_traces_test failing on ia32 pkg/vm_service/test/get_allocation_traces_test is flaky Feb 7, 2024
@bkonyi
Copy link
Contributor

bkonyi commented Feb 7, 2024

There's a history of this test flaking with the above error on all configurations (see #51487), so I don't think this is solely an IA32 issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening vm-service The VM Service Protocol, both the specification and its implementation
Projects
None yet
Development

No branches or pull requests

3 participants