Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish null-safe package_config #1537

Closed
pq opened this issue Dec 9, 2020 · 8 comments
Closed

publish null-safe package_config #1537

pq opened this issue Dec 9, 2020 · 8 comments

Comments

@pq
Copy link
Member

pq commented Dec 9, 2020

Once dart-lang/package_config#96 lands, are we good to publish?

What do you think @lrhn?

@pq
Copy link
Member Author

pq commented Dec 9, 2020

Is this ready to be pulled into the SDK or are there analyzer issues?

@pq
Copy link
Member Author

pq commented Dec 9, 2020

See also dart-lang/package_config#93 (comment)

@jakemac53
Copy link
Contributor

@lrhn it looks like a version was published but with -dev as the pre-release, we are using -nullsafety as the pre-release versions as an ecosystem wide convention (see public guidance here). Can you re-publish with that convention?

@devoncarew
Copy link
Member

pinging this issue as when running pub outdated, a casual read of the output makes it look like package_config does not yet have a null safe version:

the outdated for package:analyzer:

direct dependencies:   
args                    *1.6.0     *1.6.0      *1.6.0      2.0.0-nullsafety.0    
cli_util                *0.2.0     *0.2.0      *0.2.0      0.3.0-nullsafety.0    
convert                 *2.1.1     *2.1.1      *2.1.1      3.0.0-nullsafety.0    
crypto                  *2.1.5     *2.1.5      *2.1.5      3.0.0-nullsafety.0    
glob                    *1.2.0     *1.2.0      *1.2.0      2.0.0-nullsafety.0    
meta                    *1.2.4     *1.2.4      *1.2.4      1.3.0-nullsafety.6    
package_config          *1.9.3     *1.9.3      *1.9.3      2.0.0-dev             
path                    *1.7.0     *1.7.0      *1.7.0      1.8.0-nullsafety.3    
pub_semver              *1.4.4     *1.4.4      *1.4.4      2.0.0-nullsafety.0    
source_span             *1.7.0     *1.7.0      *1.7.0      1.8.0-nullsafety.4    
watcher                 *0.9.7+15  *0.9.7+15   *0.9.7+15   1.0.0-nullsafety.0 

@lrhn
Copy link
Member

lrhn commented Jan 19, 2021

I have uploaded a pubspec with version 2.0.0-nullsafety.0 and published it.

@devoncarew
Copy link
Member

Thanks!

@scheglov
Copy link
Contributor

Are we ready to pull it into SDK?
IIRC last time when I tried there were some issues with pub.
Totally might have been fixed, or plainly disremembered.

@scheglov
Copy link
Contributor

@mosuem mosuem transferred this issue from dart-lang/package_config Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants