You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This repository can not be run under Windows environment due to the path separator is not handled. The fixes could involve some OS check to use certain path separator.
Path-included-comment
For the existing path-included-comment variable like _startComment and _endComment will not be changed. instead, creates a new variable _thisScriptOS for os-specific logic
final _thisScriptOS ='bin${p.separator}update_bindings.dart';
const _thisScript ='bin/update_bindings.dart';
const _startComment ='<!-- START updated by $_thisScript. Do not modify by hand -->';
const _endComment ='<!-- END updated by $_thisScript. Do not modify by hand -->';
Only the part that effect file logic will use _thisScriptOS
Thanks for filing! I haven't dug enough to know whether this is possible, but for the comments, it might make sense to keep the paths as Uris and use toFilePath() to always get the POSIX path in the comment. This would avoid the duplicate vars.
Create from #331
This repository can not be run under Windows environment due to the path separator is not handled. The fixes could involve some OS check to use certain path separator.
Path-included-comment
For the existing path-included-comment variable like
_startComment
and_endComment
will not be changed. instead, creates a new variable_thisScriptOS
for os-specific logicOnly the part that effect file logic will use
_thisScriptOS
File, Directory
In current impilementation,
p.join()
is hard-coded with POSIX path separatorsUri().path
, which is not ideal for Windowsfix 1:
fix 2:
The text was updated successfully, but these errors were encountered: