Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with angular momentum conservation in dart 4.3.4 #424

Closed
scpeters opened this issue Jun 26, 2015 · 8 comments
Closed

Problem with angular momentum conservation in dart 4.3.4 #424

scpeters opened this issue Jun 26, 2015 · 8 comments

Comments

@scpeters
Copy link
Collaborator

Initially reported as gazebo issue 1487. We added a GetWorldAngularMomentum test, but we had to relax the tolerances for dart. This may be related to #229; I'm not sure. Also, I haven't run the test with dart 5.

@jslee02
Copy link
Member

jslee02 commented Oct 15, 2015

This issue should be resolved by #518. I will check the gazebo test again and also add an test to DART to make sure this is kept being resolved.

@scpeters
Copy link
Collaborator Author

I believe #518 improved angular momentum conservation, but the linear velocity and position seem to be much less accurate now.

@scpeters
Copy link
Collaborator Author

My last comment is based on a test using https://github.com/scpeters/benchmark

@stale
Copy link

stale bot commented Feb 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 13, 2018
@stale stale bot removed the stale label Feb 13, 2018
@acxz
Copy link
Contributor

acxz commented Feb 17, 2019

I was just going through DART issues and was wondering if we could close this issue, since it is on 4.3.4 (an outdated version).
The issue could be kept if the problem persists in the current stable branch of DART tho.

@mxgrey
Copy link
Member

mxgrey commented Feb 18, 2019

We should probably have a regression test for the issue and see that the regression test passes before we consider closing it.

@jslee02
Copy link
Member

jslee02 commented Feb 18, 2019

As a note, probably this is related to #1193.

@jslee02
Copy link
Member

jslee02 commented Jul 14, 2019

Closing this issue in favor of #1193, which I'm still working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants