-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with angular momentum conservation in dart 4.3.4 #424
Comments
This issue should be resolved by #518. I will check the gazebo test again and also add an test to DART to make sure this is kept being resolved. |
I believe #518 improved angular momentum conservation, but the linear velocity and position seem to be much less accurate now. |
My last comment is based on a test using https://github.com/scpeters/benchmark |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
I was just going through DART issues and was wondering if we could close this issue, since it is on 4.3.4 (an outdated version). |
We should probably have a regression test for the issue and see that the regression test passes before we consider closing it. |
As a note, probably this is related to #1193. |
Closing this issue in favor of #1193, which I'm still working on. |
Initially reported as gazebo issue 1487. We added a GetWorldAngularMomentum test, but we had to relax the tolerances for dart. This may be related to #229; I'm not sure. Also, I haven't run the test with dart 5.
The text was updated successfully, but these errors were encountered: