Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the distinction between hasProperties and hasStandoffProperties make sense? #760

Closed
benjamingeer opened this issue Mar 1, 2018 · 7 comments
Assignees
Labels
API/V2 question further information is requested

Comments

@benjamingeer
Copy link

benjamingeer commented Mar 1, 2018

In the JSON-LD returned by the ontology routes, some properties go in hasProperties (if they’re used on resources or values), and others go in hasStandoffProperties (if they’re used on standoff tags). But what if a property is used both on values and on standoff tags (like valueHasUri)? Where should it go? Should we even have this distinction, or could we get rid of it?

@benjamingeer benjamingeer added question further information is requested API/V2 labels Mar 1, 2018
@benjamingeer
Copy link
Author

And actually, do we need hasStandoffClasses? Could we just have a boolean isStandoffTag on each standoff class?

@tobiasschweizer
Copy link
Contributor

tobiasschweizer commented Mar 1, 2018

Could we just have a boolean isStandoffTag on each standoff class?

I guess that would make sense. Actually, we also flagged value classes in a way so they can be distinguished from resource classes. So we could also flag standoff classes.

@benjamingeer
Copy link
Author

OK, so I will make it like this:

  • hasClasses
  • hasProperties
  • hasIndividuals

And I will add flags to distinguish resource classes from standoff classes, and resource properties from standoff properties.

@tobiasschweizer
Copy link
Contributor

Just keep in mind that the ontology service in the SALSAH GUI might have to be adapted accordingly.

@benjamingeer
Copy link
Author

Actually, sorry, what I just said makes no sense, because is valueHasUri a standoff property? It's used in standoff classes but also in values.

Do we actually need to flag standoff properties? Isn't it enough that we have the cardinalities in standoff classes, to find out which properties they need?

@tobiasschweizer
Copy link
Contributor

If they show up like other properties, the GUI will display them in the extended search form if they cannot be distinguished from other props.

@benjamingeer
Copy link
Author

If they show up like other properties, the GUI will display them in the extended search form if they cannot be distinguished from other props.

Doesn't that just mean that the GUI needs to know which properties are resource properties (which it should use in the extended search form)? Why would it need to distinguish between, say, valueHasColor (which is used in StandoffColorTag as well as in ColorValue) and dimX (which is used in StillImageFileValue but not in any standoff tag)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API/V2 question further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants