fix: footnotes escape html only once #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # libs/vre/pages/ontology/ontology-classes/src/lib/list-view/resource-list/resource-list.component.html # libs/vre/resource-editor/resource-properties/src/lib/switch-components/rich-text-switch.component.ts # libs/vre/resource-editor/resource-properties/src/lib/switch-components/text-html-switch.component.ts # libs/vre/ui/ui/src/index.ts # libs/vre/ui/ui/src/ui.components.ts
# Conflicts: # libs/vre/resource-editor/resource-properties/src/lib/footnote-parser.pipe.ts
irmastnt
approved these changes
Feb 10, 2025
mpro7
approved these changes
Feb 10, 2025
| @@ -0,0 +1,10 @@ | |||
| export function unescapeHtml(str: string) { | |||
There was a problem hiding this comment.
Does it make sense to extract this single function like that? Would it make more sense to keep it where it was or move it to CkEditorComponent or ideally to service which handles footnote (not sure if this exists, but if not creating it for single function doesn't make sense).
There was a problem hiding this comment.
it is used in two different nx libs so to me that seems like the cleanest way
irmastnt
added a commit
that referenced
this pull request
Feb 11, 2025
…ist-values-leads-to-randomly * main: chore(deps-dev): bump prettier from 3.4.2 to 3.5.0 (#2094) chore(deps-dev): bump @typescript-eslint/utils from 8.22.0 to 8.24.0 (#2099) chore(deps): bump the grafana-deps group across 1 directory with 2 updates (#2100) chore: add CODEOWNERS file (#2095) fix: update footnote plugin (ckeditor5) to 2.1.5 (#2096) chore: add tsc command to nx projects (#2097) chore(main): release 11.25.1 (#2083) fix: footnotes escape html only once (#2088) fix: selected region click only fires when a region iri is found (#2089) refactor: remove unused variables (#2086) # Conflicts: # package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug of a footnote being html escaped twice (now once)
in
<footnote content="ESCAPING" />