-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project's test are failing - help to debug greatly appreciated #709
Comments
The new package is "HeapDict", which was last updated 2019. Looks like dask/cachey pulls in HeapDict, not sure how dask/cachey is getting in here, it hasn't been touched since 2020 and only depends on HeapDict. https://libraries.io/pypi/HeapDict |
dask/zict used to depend on it, maybe this is more promissing. |
Well this all seems coincident with Dask dropping support for python 3.8. Try making dask and distributed depend on >=2022.4.0,<2023.5.1 or just drop support for 3.8 here too |
I've concluded that the issue is that the golang binary isn't being built in #739 where I added an explicit check for this. I think its related to how we make it build through stuff going on in setup.py. I suspect a modern version of pip or setuptools etc made this no longer work. Here is the changelog for 23.1 that was released april 15th. Last test succeeded april 10th, so it seems very relevant https://pip.pypa.io/en/stable/news/#v23-1 |
It appears that we have started to get failures in the CI system without actually making a change to the repository, so something changed elsewhere which caused these failures.
But what?
Difference in python test dependencies installed (python 3.10 test):
Suspciuos difference in behavior, from setup.py focus (working)...
To a pyproject.toml focus (not working). but note that the python packages are put in dedicated folders, and they don't contain a pyproject.toml - the root directory does to provide config for black/isort etc.
The text was updated successfully, but these errors were encountered: