-
-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numpy is imported unconditionally #5729
Comments
Not that simple - |
Blosc/python-blosc#159 seems stalled, but we could probably suggest just not importing the tests in top-level |
WON'T FIX#5750 introduces a new unconditional import of numpy, whose benefits definitely exceed those of this ticket. |
If you can think of better ways to handle that |
We have many unit tests that generate Nannies with spawn method. In theory, those tests should become a lot faster if numpy was imported only if needed.
This is not the case today, because of
get_versions
without importing packages #5724import blosc
statements indistributed.protocol.compression
xfailed unit test is already in #5695.
Note that this means that fixing this issue means that, across all unit tests that do use numpy data on nannies,
import numpy
will be moved from@gen_cluster
start to the first time where a numpy array or function is deserialised - which in turn may cause flakiness if the test time margins are too tight.CC @gjoseph92
The text was updated successfully, but these errors were encountered: