Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API change in #6363 broke dask gateway #6559

Closed
TomAugspurger opened this issue Jun 10, 2022 · 4 comments · Fixed by #6561
Closed

API change in #6363 broke dask gateway #6559

TomAugspurger opened this issue Jun 10, 2022 · 4 comments · Fixed by #6561

Comments

@TomAugspurger
Copy link
Member

In #6363, a parameter was removed that makes distributed in compatible with Dask Gateway: dask/dask-gateway#573

I'd recommend we restore that parameter and deprecate it. If it's impossible to restore the previous functionality, we could restore the parameter and perhaps ignore it, just for the signature compatibility (I don't know if dask-gateway was relying on the previous behavior).

@jrbourbeau
Copy link
Member

Looking at the linked dask-gateway PR, it looks like removing the fast= keyword from Scheduler.close is the parameter you're referring to @TomAugspurger. cc @fjetter @gjoseph92 who were actively involved on #6363

@mrocklin
Copy link
Member

Question, are we doing upstream testing in dask-gateway? If not, does anyone want to take this on? (@TomAugspurger ?)

@jrbourbeau
Copy link
Member

From a functional perspective, looking at the Scheduler.close source from an earlier distributed release, it looks like fast= wasn't actually being used

@TomAugspurger
Copy link
Member Author

#6561 has a quick fix up for this.

I'm not sure if dask-gateway is testing against upstream (I didn't see anything at a glance). I might be able to add that this weekend or next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants