Fix pytest.config deprecation warning #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jrbourbeau ! |
QuLogic
pushed a commit
to QuLogic/distributed
that referenced
this pull request
May 15, 2019
muammar
added a commit
to muammar/distributed
that referenced
this pull request
Jul 18, 2019
* upstream/master: Add WeakSet _instances attributes to all classes (dask#2673) Cap worker's memory limit by the hard limit of the maximum resident memory (dask#2665) Switch from (ip, port) to address in tests (dask#2684) Catch RuntimeError to avoid serialization fail when using pytorch (dask#2619) Add CONTRIBUTING.md (dask#2680) Consolidate logic around services (dask#2679) Fix uri_from_host_port import in dask-mpi (dask#2683) Move dashboard_address logic into Scheduler/Worker (dask#2678) Fix pytest.config deprecation warning (dask#2677) Use config accessor method for "scheduler-address" (dask#2676) Add memory and disk aliases to Worker.data (dask#2670) Move interface/host/port handling from CLI to classes (dask#2667) Remove AioClient (dask#2668) Add release procedure doc (dask#2672) bump version to 1.28.0
Lnaden
added a commit
to Lnaden/QCFractal
that referenced
this pull request
Aug 20, 2019
This PR makes an overhaul to the nuances of our PyTest framework.
* In order to ship around the testing configuration (the contents of
`conftest.py`), this PR ports all of those features to the `testing.py`
file which is now treated as a first class PyTest Plugin.
* The `pytest11` entry point for the `testing.py` file has been added
to the `setup.py` file so it will be detected automatically by any
installed PyTest, allowing transferring of the `--runslow` and
`--runexamples` CLI flags into PyTest on its own.
* This also enables the ability to access these flags anywhere
* Due to the removal of the [pytest.config global](https://docs.pytest.org/en/latest/deprecations.html#pytest-config-global) in the Version 5+ of PyTest, I had to
rework how some of our `mark` functions behave. Instead of writing
our own decorators, I instead am using the PyTest recommended method
of `pytest_collection_modifyitems`, an example of which can be found
[here](https://docs.pytest.org/en/latest/example/simple.html#control-skipping-of-tests-according-to-command-line-option).
I have also based this off the implementation this from Dask Distributed
dask/distributed#2677.
* Due to the previous change, the `mark_slow` and `mark_example`
decorators are no more. We now just use `pytest.mark.slow` and
`pytest.mark.example` respectively. This change has been propagated
through the tests.
* I fixed a bug in the `test_visualization` where the `_has_plotly` flag
was always being set to `True`.
* I have tested this with both PyTest 5 and PyTest 4.6.3
And finally, all of this, was so we could install QCFractal and run
`pytest --pyargs qcfractal` from anywhere and still have access to the
optional `--runslow` flag (and it solved a PyTest 5 deprecation)
2 tasks
QCArchiveBot
pushed a commit
to MolSSI/QCPortal
that referenced
this pull request
Aug 20, 2019
This PR makes an overhaul to the nuances of our PyTest framework.
* In order to ship around the testing configuration (the contents of
`conftest.py`), this PR ports all of those features to the `testing.py`
file which is now treated as a first class PyTest Plugin.
* The `pytest11` entry point for the `testing.py` file has been added
to the `setup.py` file so it will be detected automatically by any
installed PyTest, allowing transferring of the `--runslow` and
`--runexamples` CLI flags into PyTest on its own.
* This also enables the ability to access these flags anywhere
* Due to the removal of the [pytest.config global](https://docs.pytest.org/en/latest/deprecations.html#pytest-config-global) in the Version 5+ of PyTest, I had to
rework how some of our `mark` functions behave. Instead of writing
our own decorators, I instead am using the PyTest recommended method
of `pytest_collection_modifyitems`, an example of which can be found
[here](https://docs.pytest.org/en/latest/example/simple.html#control-skipping-of-tests-according-to-command-line-option).
I have also based this off the implementation this from Dask Distributed
dask/distributed#2677.
* Due to the previous change, the `mark_slow` and `mark_example`
decorators are no more. We now just use `pytest.mark.slow` and
`pytest.mark.example` respectively. This change has been propagated
through the tests.
* I fixed a bug in the `test_visualization` where the `_has_plotly` flag
was always being set to `True`.
* I have tested this with both PyTest 5 and PyTest 4.6.3
And finally, all of this, was so we could install QCFractal and run
`pytest --pyargs qcfractal` from anywhere and still have access to the
optional `--runslow` flag (and it solved a PyTest 5 deprecation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all occurrences of
distributed.utils_test.slowwithpytest.mark.slow.Fixes #2669