Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget: Update accident_count_by_accident_type widget #1

Open
ziv17 opened this issue Mar 10, 2022 · 3 comments
Open

Widget: Update accident_count_by_accident_type widget #1

ziv17 opened this issue Mar 10, 2022 · 3 comments

Comments

@ziv17
Copy link

ziv17 commented Mar 10, 2022

This issue is to coordinate the work on BE issue 2122 with same name:
Name
Required changes to widget accident count by accident type

Title
accident_count_by_accident_type widge

Required changes
• Add Title - years and widget name to heading (BE & FE)
• Add filter “top 3 types” results (BE)
• Pie will display only “top 3 types” results (FE)
• Enlarge pie size (FE)
• Remove years details below (?)
• Add information text (BE)

Visualization explanation
New display
image

Current display
image

Use case
When this infographic should be displayed: allways

Information Tag
Will include the following description:
התפלגות תאונות לפי סוג התאונה במקטע, בפרק הזמן הנבחר. מוצגים 3 סוגי התאונות הנפוצים ביותר במקטע זה.

Additional context

Definition will be used by BE team to generate a Json response to FE
Definition will be provided by Data team, after internal review
Definition will be written in English and should use language agnostic definitions and data structures
(e.g. SQL columns) as much as possible.
@danielsh28
Copy link

@ziv17 @MichalOren are these changes also apply to accident_count_by_driver_type? or maybe just some of them? we have an issue in progress on that data-for-change/anyway-newsflash-infographics#859

@MichalOren
Copy link

Hi @danielsh28 we usually open issues per widget. Even if the changes are similar or identical, just to avoid any misunderstanding. etch widget is in a different stage of implementation

@MichalOren
Copy link

this is the original link with wireframe data-for-change/anyway#2122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants