Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social links (GitHub, YouTube, website): match icons #404

Open
reshamas opened this issue Apr 11, 2023 · 4 comments
Open

Social links (GitHub, YouTube, website): match icons #404

reshamas opened this issue Apr 11, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@reshamas
Copy link
Contributor

Some social icons render. Others do not.

These work: LinkedIn, Twitter

These do not work: GitHub, YouTube, ?website

Screen Shot 2023-04-11 at 10 08 54 AM

@jtorreggiani
Copy link
Contributor

@reshamas, to add support for other social media company you can add icons to this component https://github.com/data-umbrella/event-board-web/blob/main/src/components/elements/ShareLinkIcon.jsx.

All the icons available can be found here https://react-icons.github.io/react-icons/icons?name=si.

@jtorreggiani jtorreggiani added enhancement New feature or request good first issue Good for newcomers labels Apr 13, 2023
@nikita22panwar
Copy link

@reshamas @jtorreggiani is it open for contribution
if yes can you add the label of hacktoberfest

@reshamas
Copy link
Contributor Author

reshamas commented Oct 7, 2023

@reshamas is it open for contribution if yes can you add the label of hacktoberfest

@nikita22panwar hacktoberfest label added. :)

@reshamas
Copy link
Contributor Author

reshamas commented Oct 7, 2023

@nikita22panwar We don't assign issues. Here are the instructions in the Contributing Guide:
https://github.com/data-umbrella/event-board-web/blob/main/CONTRIBUTING.md#contributing-guidelines

  • To claim an issue, write "I am working on it" in a comment and then you can start working on it; there is no need to wait to be assigned on an issue.
  • A pull request should be submitted within two weeks or someone else can work on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants