Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is est? #11

Open
nsheff opened this issue Jul 18, 2019 · 2 comments
Open

What is est? #11

nsheff opened this issue Jul 18, 2019 · 2 comments

Comments

@nsheff
Copy link
Member

nsheff commented Jul 18, 2019

logmuse is held in a file called est.py. What does this name mean? Can we name it something more understandable?

@vreuter
Copy link
Member

vreuter commented Jan 9, 2020

Yeah, it'd be fine to change. I think I called it that as short for "establish" since it's home to the main setup functions. The only problem I'd see is breaking imports, but I think the package __init__ and the __all__ declarations are set up to expose at top level anything that's intended for import and use outside of the package itself, so ideally client code is importing from logmuse directly rather than the est module and would be safe.

@nsheff
Copy link
Member Author

nsheff commented Jan 9, 2020

Ok thanks. when we get to this we should also consider: pepkit/looper#224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants