Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Please support defining the deployment in yaml instead of json. #39

Closed
jspreddy opened this issue May 4, 2021 · 3 comments
Closed
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@jspreddy
Copy link
Contributor

jspreddy commented May 4, 2021

Current Behavior

The deployment is defined in conf/deployment.json.

JSON is cumbersome to read and write. Not to mention it causes duplication of config.

Context

  1. I want to be able to not duplicate config.
  2. I want to extract common config and include it in the job definitions.
  3. I want to reduce human error when configuring the jobs.
  4. I want to be able to extend/add functionality to the deployment config file in the future.

Proposal

  1. Allow --deployment-file to take a deployment(.json | .yaml | .yml) file.
  2. By default check for deployment(.json | .yaml | .yml) file in the conf folder.
  3. Parse the file appropriately.

Your Environment

  • dbx version used: DataBricks eXtensions aka dbx, version ~> 0.1.2
  • Databricks Runtime version: 8.1, 8.2
@renardeinside renardeinside changed the title [Feature Request] Please support defining the deployment in yaml instead of json. [FEATURE] Please support defining the deployment in yaml instead of json. May 11, 2021
@renardeinside renardeinside modified the milestones: 0.1.3, 0.1.4 May 15, 2021
@renardeinside
Copy link
Contributor

hi @jspreddy ,

would you like to volunteer and provide a PR with implementation?

@renardeinside renardeinside added enhancement New feature or request help wanted Extra attention is needed labels Jun 14, 2021
@renardeinside renardeinside modified the milestones: 0.1.4, 0.1.5 Jul 22, 2021
@jspreddy jspreddy mentioned this issue Aug 4, 2021
8 tasks
@renardeinside
Copy link
Contributor

Just released in 0.1.5. Thank you @jspreddy for investing your time into this and making the whole implementation! 🔥

@jspreddy
Copy link
Contributor Author

The changelog is not properly updated for the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants