Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SplitPart expression #1415

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Refactor SplitPart expression #1415

wants to merge 4 commits into from

Conversation

vijaypavann-db
Copy link
Contributor

Removed local_expression.SplitPart and refactored to sqlglot expression.SplitPart.

Closes #1411

@vijaypavann-db vijaypavann-db added the bug Something isn't working label Jan 9, 2025
@vijaypavann-db vijaypavann-db self-assigned this Jan 9, 2025
@vijaypavann-db vijaypavann-db requested a review from a team as a code owner January 9, 2025 08:06
ericvergnaud
ericvergnaud requested changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ericvergnaud ericvergnaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to move to remorph-community-transpiler

bishwajit-db
bishwajit-db approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@bishwajit-db bishwajit-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sundarshankar89
Copy link
Collaborator

@ericvergnaud Eventually, it will, I think, given the interdependency between reconcile depending on custom dialects, we will have to keep this operational within this repo.

sundarshankar89
sundarshankar89 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sundarshankar89
Copy link
Collaborator

@ericvergnaud Eventually, it will, I think, given the interdependency between reconcile depending on custom dialects, we will have to keep this operational within this repo.

@gueniai Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvergnaud ericvergnaud ericvergnaud requested changes

@bishwajit-db bishwajit-db bishwajit-db approved these changes

@sundarshankar89 sundarshankar89 sundarshankar89 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@vijaypavann-db vijaypavann-db

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Use sqlglot.expression.SplitPart instead of local_expression.SplitPart in the custom dialects
4 participants
@vijaypavann-db @sundarshankar89 @ericvergnaud @bishwajit-db