-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphene v3 support? #45
Comments
I was playing around with this a bit earlier but I couldn't quite get it working. I fear I'm not familiar enough with the recent changes. |
@prokher is this on your roadmap by any chance? or are you guys staying on v2? |
Any update? |
As far as I see, v3 is not released yet. I see only the beta version v3.0.0.b6 available. Once the final/stable release is here, I will try to migrate BTW, didn't they implemented the WebSocket protocol with subscriptions on their own? 🤔 Honestly speaking, I think that the functionality implemented here in |
@prokher , it appears they have a desire to wait for two daughter projects, who have pinned to |
With the two daughter projects now supporting graphene v3, it looks like we are finally heading towards a release: graphql-python/graphene#1127 (comment). Are there still plans for |
As far as I see, Graphene v3 is still in beta. We will proceed as soon as stable version is here. |
@prokher graphene is still in beta, but should release shortly as the rest of the ecosystem has now gained v3 support. The API is not going to change at this point, so I don't see a reason why this project shouldn't plot a course for v3. I will take another look at this tomorrow and see what the state of the universe is. |
Graphene v3 has just been released :D https://github.com/graphql-python/graphene/releases/tag/v3.0.0 |
Would be great to have this! |
Apparently, integration with graphene 3 is not so simple. |
Definitely agree, I ended up having a custom solution for our use-case which circumvents the GraphQL engine on return of the message. I can see how it is tricky with the new Graphene3 ExecutionResult and it seems like it might be hard to have a generic solution, one good example might be how https://github.com/jaydenwindle/graphene-subscriptions is working with Rx Subjects. |
I've spent a bit of time trying to do this refactor, got some of the way there but hit a wall when using https://github.com/tomjohnhall/DjangoChannelsGraphqlWs/tree/gql-graphene-3 Concepts like asyncio and Rx are new to me so this is mostly trial and error. If anyone with a better grasp is interested in taking a look or comparing their own implementation, please do! |
The version 1.0.0rc1 is available in PyPI, it supports latest Django & Graphene, so I am closing this. Feel free to reopen or file a new issue in case of problems. |
is there any plan to support v3 of graphene?
if it's already in the roadmap, i can help to test :)
The text was updated successfully, but these errors were encountered: