From e9176d2cd250db3d5f3c08175f16fe46fdb6ae5f Mon Sep 17 00:00:00 2001 From: Harshal Sheth Date: Fri, 30 Dec 2022 14:54:43 -0500 Subject: [PATCH] docs(ingest/looker): fix typos + update lookml github action example (#6910) --- metadata-ingestion/docs/sources/looker/looker_pre.md | 2 +- metadata-ingestion/docs/sources/looker/lookml_pre.md | 11 +++++------ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/metadata-ingestion/docs/sources/looker/looker_pre.md b/metadata-ingestion/docs/sources/looker/looker_pre.md index 762b4d0f5af48e..ad7fff9c0daafe 100644 --- a/metadata-ingestion/docs/sources/looker/looker_pre.md +++ b/metadata-ingestion/docs/sources/looker/looker_pre.md @@ -1,4 +1,4 @@ -### Pre-Requisites +### Prerequisites #### Set up the right permissions You need to provide the following permissions for ingestion to work correctly. diff --git a/metadata-ingestion/docs/sources/looker/lookml_pre.md b/metadata-ingestion/docs/sources/looker/lookml_pre.md index 9ddca3aa2d628e..e6528c89cf43f5 100644 --- a/metadata-ingestion/docs/sources/looker/lookml_pre.md +++ b/metadata-ingestion/docs/sources/looker/lookml_pre.md @@ -1,4 +1,4 @@ -### Pre-requisites +### Prerequisites #### [Recommended] Create a GitHub Deploy Key @@ -69,15 +69,14 @@ You need to set up the following secrets in your GitHub repository to get this w - LOOKER_CLIENT_ID: A provisioned Looker Client ID - LOOKER_CLIENT_SECRET: A provisioned Looker Client Secret -``` +```yml name: lookml metadata upload on: + # Note that this action only runs on pushes to your main branch. If you want to also + # run on pull requests, we'd recommend running datahub ingest with the `--dry-run` flag. push: branches: - main - paths-ignore: - - "docs/**" - - "**.md" release: types: [published, edited] workflow_dispatch: @@ -90,7 +89,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-python@v4 with: - python-version: '3.9' + python-version: '3.10' - name: Run LookML ingestion run: | pip install 'acryl-datahub[lookml,datahub-rest]'