Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues from glossary term load on dataset page #6395

Closed
Reilman79 opened this issue Nov 9, 2022 · 2 comments
Closed

Performance issues from glossary term load on dataset page #6395

Reilman79 opened this issue Nov 9, 2022 · 2 comments
Assignees

Comments

@Reilman79
Copy link
Contributor

The problem

When a dataset page is loaded it calls the getDataset() graphql function to populate the info on the page. Due to various levels of fragment abstraction, this function also pulls the total child counts for each parent glossary node of each glossary term linked to the dataset or its fields. For datasets with a large number of glossary terms linked, this can result in potentially hundreds of duplicate calls to the graph database (e.g. a dataset with 150 terms, each term having 2 parent nodes, will result in 300 additional queries to the graph db). This can severely hurt performance or result in the database connections timing out and the page failing to load entirely.

Proposed fix

Glossary node children totals do not appear to be needed on the dataset page, so removing that portion of the getDataset() query should improve performance in this scenario.

@aditya-radhakrishnan
Copy link
Contributor

@chriscollins3456 can you close this out when this gets merged? Thanks!

@chriscollins3456
Copy link
Collaborator

Thanks @Reilman79! i'll close this issue for now, but feel free to reopen if you don't see the performance improvements we're looking for here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants