Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mssql - error with database that has table or column description #6717

Closed
oleg-ruban opened this issue Dec 9, 2022 · 4 comments
Closed

mssql - error with database that has table or column description #6717

oleg-ruban opened this issue Dec 9, 2022 · 4 comments
Labels
bug Bug report ingestion PR or Issue related to the ingestion of metadata stale

Comments

@oleg-ruban
Copy link

Describe the bug
Problem with Microsoft SQL Server ingest source. During ingestion for database that has table or column description error occur.

To Reproduce
Steps to reproduce the behavior:

  1. Create mssql yml configuration
    source:
      type: mssql
      config:
        # Coordinates
        host_port: localhost:1433
        database:  database

        # Credentials
        username: username
        password: password

        # Options
        use_odbc: "True"
        uri_args:
          driver: "ODBC Driver 17 for SQL Server"
          Encrypt: "yes"
          TrustServerCertificate: "Yes"
          ssl: "True"
    sink:
      type: "datahub-rest"
      config:
        server: "http://127.0.0.1:8080"
  1. Install latest version datahub mssql module
    pip install acryl-datahub[mssql]==0.9.3
  2. Add description to table or column in database
  3. Run command to ingest data
    datahub ingest -c ./<mssql yml name>.yml
  4. See error
    Table description error example
    ProgrammingError: (pyodbc.ProgrammingError) ('ODBC SQL type -150 is not yet supported. column-index=2 type=-150', 'HY106') (Background on this error at: http://sqlalche.me/e/13/f405)
    Column description error example
    ProgrammingError: (pyodbc.ProgrammingError) ('ODBC SQL type -150 is not yet supported. column-index=3 type=-150', 'HY106') (Background on this error at: http://sqlalche.me/e/13/f405)

Expected behavior
Pipeline finished successfully

Screenshots
Table description error
image

Column description error
image

Desktop (please complete the following information):

  • OS: [Windows, Ubuntu]
  • Browser [chrome]
  • Version [103.0.5]

DataHub libraries info:

  • DataHub CLI version [0.9.3]
  • Python version: [3.8.0]
  • SQLAlchemy [1.3.24]
  • pyodbc [4.0.32]
  • sqlalchemy-pytds [0.3.4]
  • Additional context

Quick solution proposal:

  • add flag include_column_description
  • add flag include_table_description
@oleg-ruban oleg-ruban added the bug Bug report label Dec 9, 2022
@laulpogan laulpogan added the ingestion PR or Issue related to the ingestion of metadata label Dec 12, 2022
@oleg-ruban
Copy link
Author

This is reproducible on 0.9.5

@hsheth2
Copy link
Collaborator

hsheth2 commented Jan 18, 2023

@oleg-ruban that's definitely surprising - this PR #6134 was supposed to have fixed the issue

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

@github-actions github-actions bot added the stale label Feb 18, 2023
@github-actions
Copy link

This issue was closed because it has been inactive for 30 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report ingestion PR or Issue related to the ingestion of metadata stale
Projects
None yet
Development

No branches or pull requests

3 participants