Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft deleted entity ML Model still appears in the UI (reopened) #7120

Closed
jazzblue opened this issue Jan 24, 2023 · 1 comment
Closed

Soft deleted entity ML Model still appears in the UI (reopened) #7120

jazzblue opened this issue Jan 24, 2023 · 1 comment
Assignees
Labels
bug Bug report product PR or Issue related to the DataHub UI/UX

Comments

@jazzblue
Copy link

jazzblue commented Jan 24, 2023

This issue was closed incorrectly, please see:
#6328

The meaning of soft delete is that it can be restored, but while it is in soft deleted state it is deleted as far as any user whether API or UI. The soft deleted entity should not appear in the UI. This is a real problem and should be fixed.
I am reopening it here.

@jazzblue jazzblue added the bug Bug report label Jan 24, 2023
@aditya-radhakrishnan aditya-radhakrishnan self-assigned this Jan 24, 2023
@aditya-radhakrishnan aditya-radhakrishnan added the product PR or Issue related to the DataHub UI/UX label Jan 24, 2023
@aditya-radhakrishnan
Copy link
Contributor

Hey @jazzblue sorry if we closed that issue before you felt it was resolved.

The DataHub Core Team has decided that yes, soft deletion, means it can be restored, but we have implemented it so that soft deletion means the entity can appear in the UI. It will not be discoverable via Search or other mechanisms though.

If you would like something to not appear in the UI and you have no need for that metadata anymore, I would recommend you hard delete.

Hope that makes things clear. Thank you for engaging in the community!

@aditya-radhakrishnan aditya-radhakrishnan closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

No branches or pull requests

2 participants