Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Misc updates for tests, auth log level, and quickstart #6491

Merged
merged 1 commit into from
Nov 29, 2022
Merged

fix(tests): Misc updates for tests, auth log level, and quickstart #6491

merged 1 commit into from
Nov 29, 2022

Conversation

david-leifker
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX labels Nov 18, 2022
@github-actions
Copy link

github-actions bot commented Nov 18, 2022 •
edited
Loading

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 51s ⏱️ -8s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 9eeaff1. ± Comparison against base commit 250f7ce.

♻️ This comment has been updated with latest results.

@david-leifker david-leifker force-pushed the david-leifker/misc_test_updates branch from c8691c3 to 9eeaff1 Compare November 18, 2022 16:24
jjoyce0510
jjoyce0510 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall these changes LGTM.

@jjoyce0510 jjoyce0510 merged commit a2dc229 into datahub-project:master Nov 29, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@david-leifker @cccs-Dustin
fix(tests): Misc updates for tests, auth log level, and quickstart (d…
a4efd48 
…atahub-project#6491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @jjoyce0510