[Bug report] TrinoContainer#checkSyncCatalogFromGravitino will always return false
#3237
Assignees
Labels
bug
Something isn't working
Comments
xiaozcy
changed the title
TrinoContainer#checkSyncCatalogFromGravitino will always return falseTrinoContainer#checkSyncCatalogFromGravitino will always return false
yuqi1129
pushed a commit
that referenced
this issue
May 1, 2024
### What changes were proposed in this pull request? use simple catalog name in `com.datastrato.gravitino.integration.test.container.TrinoContainer#checkSyncCatalogFromGravitino`, and verify it where it is called. ### Why are the changes needed? Fix: #3237 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ITs --------- Co-authored-by: zhanghan18 <[email protected]>
github-actions bot
pushed a commit
that referenced
this issue
May 1, 2024
### What changes were proposed in this pull request? use simple catalog name in `com.datastrato.gravitino.integration.test.container.TrinoContainer#checkSyncCatalogFromGravitino`, and verify it where it is called. ### Why are the changes needed? Fix: #3237 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ITs --------- Co-authored-by: zhanghan18 <[email protected]>
|
@xiaozcy |
yuqi1129
pushed a commit
that referenced
this issue
May 1, 2024
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this issue
Jun 13, 2024
…pache#3238) ### What changes were proposed in this pull request? use simple catalog name in `com.datastrato.gravitino.integration.test.container.TrinoContainer#checkSyncCatalogFromGravitino`, and verify it where it is called. ### Why are the changes needed? Fix: apache#3237 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ITs --------- Co-authored-by: zhanghan18 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
main branch
Describe what's wrong
In #2433 , we use simple catalog name in Trino connector. In that case, when we execute
SHOW CATALOGSin Trino, it returns the original catalog names in Trino (without{metalake}.prefix).But in
com.datastrato.gravitino.integration.test.container.TrinoContainer#checkSyncCatalogFromGravitino, we useformat("SHOW CATALOGS LIKE '%s.%s'", metalakeName, catalogName)to match the result of the execution, which means this method will always returnfalse. Besides, we never verify the return value of this method where it is called, so the current test can still be executed successfully.Error message and/or stacktrace
N/A
How to reproduce
Use
format("SHOW CATALOGS LIKE '%s'", catalogName)instead, and verify the return value of this method where it is called.Additional context
No response
The text was updated successfully, but these errors were encountered: