Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Filter system database when list database for Doris catalogs #3275

Closed
yuqi1129 opened this issue May 6, 2024 · 0 comments · Fixed by #3276
Closed

[Improvement] Filter system database when list database for Doris catalogs #3275

yuqi1129 opened this issue May 6, 2024 · 0 comments · Fixed by #3276
Assignees
Labels
improvement Improvements on everything

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented May 6, 2024

What would you like to be improved?

There are currently system databases that can be listed, such as "information_schema." We should maintain their consistency with other jdbc catalogs like MySQL and PostgreSQL

How should we improve?

No response

@yuqi1129 yuqi1129 added the improvement Improvements on everything label May 6, 2024
@yuqi1129 yuqi1129 self-assigned this May 6, 2024
FANNG1 pushed a commit that referenced this issue May 6, 2024
…tion_schema` for Doris catalog. (#3276)

### What changes were proposed in this pull request?

Filter system database `information_schema` when `list` or `get` table
for Doris catalogs.

### Why are the changes needed?

The system database/table should not be accessible to users directly,
and both MySQL and PG have filtered it.

Fix: #3275 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Added test `testListSystemDatabase`.
github-actions bot pushed a commit that referenced this issue May 6, 2024
…tion_schema` for Doris catalog. (#3276)

### What changes were proposed in this pull request?

Filter system database `information_schema` when `list` or `get` table
for Doris catalogs.

### Why are the changes needed?

The system database/table should not be accessible to users directly,
and both MySQL and PG have filtered it.

Fix: #3275 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Added test `testListSystemDatabase`.
yuqi1129 added a commit that referenced this issue May 6, 2024
…tion_schema` for Doris catalog. (#3284)

### What changes were proposed in this pull request?

Filter system database `information_schema` when `list` or `get` table
for Doris catalogs.

### Why are the changes needed?

The system database/table should not be accessible to users directly,
and both MySQL and PG have filtered it.

Fix: #3275 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Added test `testListSystemDatabase`.

Co-authored-by: Qi Yu <[email protected]>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
…nformation_schema` for Doris catalog. (apache#3276)

### What changes were proposed in this pull request?

Filter system database `information_schema` when `list` or `get` table
for Doris catalogs.

### Why are the changes needed?

The system database/table should not be accessible to users directly,
and both MySQL and PG have filtered it.

Fix: apache#3275 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Added test `testListSystemDatabase`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on everything
Projects
None yet
2 participants