Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] Gravitino icon doesn't show on UI #3413

Closed
ch3yne opened this issue May 16, 2024 · 1 comment · Fixed by #3416
Closed

[Bug report] Gravitino icon doesn't show on UI #3413

ch3yne opened this issue May 16, 2024 · 1 comment · Fixed by #3416
Assignees
@LauraXia123
Labels
bug Something isn't working

Comments

@ch3yne
Copy link
Contributor

ch3yne commented May 16, 2024

Version

main branch

Describe what's wrong

image

Error message and/or stacktrace

N/A

How to reproduce

N/A

Additional context

No response
@ch3yne ch3yne added the bug Something isn't working label May 16, 2024
@ch3yne ch3yne self-assigned this May 16, 2024
@ch3yne ch3yne mentioned this issue May 16, 2024
Closed
@LauraXia123
Copy link
Collaborator

Set the overridesrc for is ok.
I'll submit a new pr instead of the workaround solutions
@ch3yne

LauraXia123 added a commit to LauraXia123/gravitino that referenced this issue May 16, 2024
@LauraXia123
[apache#3413] fix(web): fix logo error
1e18f91
@LauraXia123 LauraXia123 assigned LauraXia123 and unassigned ch3yne May 16, 2024
@LauraXia123 LauraXia123 mentioned this issue May 16, 2024
Merged
github-actions bot pushed a commit that referenced this issue May 17, 2024
@LauraXia123 @web-flow
[#3413] fix(web): fix logo error (#3416)
e741709 
### What changes were proposed in this pull request?

fix next/image component src issue

### Why are the changes needed?

Fix: #3413

### Does this PR introduce _any_ user-facing change?
Before
<img width="192" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/2fb06a60-47fa-4695-b00d-059e54e3ab9a">
After
<img width="179" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/d89abfe0-db4e-45ef-9ea5-bd3a2cf2196e">


### How was this patch tested?

smoke test
@jerryshao jerryshao mentioned this issue May 17, 2024
Merged
yuqi1129 pushed a commit that referenced this issue May 18, 2024
@jerryshao @LauraXia123
[#3413] fix(web): fix logo error (#3433)
ebe2de7 
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

fix next/image component src issue

### Why are the changes needed?

Fix: #3413

### Does this PR introduce _any_ user-facing change?
Before
<img width="192" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/2fb06a60-47fa-4695-b00d-059e54e3ab9a">
After
<img width="179" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/d89abfe0-db4e-45ef-9ea5-bd3a2cf2196e">


### How was this patch tested?

smoke test

Co-authored-by: Qian Xia <[email protected]>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@LauraXia123 @diqiu50
[apache#3413] fix(web): fix logo error (apache#3416)
6ef086a 
### What changes were proposed in this pull request?

fix next/image component src issue

### Why are the changes needed?

Fix: apache#3413

### Does this PR introduce _any_ user-facing change?
Before
<img width="192" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/2fb06a60-47fa-4695-b00d-059e54e3ab9a">
After
<img width="179" alt="image"
src="https://github.com/datastrato/gravitino/assets/9210625/d89abfe0-db4e-45ef-9ea5-bd3a2cf2196e">


### How was this patch tested?

smoke test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LauraXia123 LauraXia123

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@LauraXia123 @ch3yne