Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep AES secret #110

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Keep AES secret #110

merged 1 commit into from
Jul 20, 2020

Conversation

inercia
Copy link
Contributor

@inercia inercia commented Jul 17, 2020

Keep the AES secret on deletions.

@weitzj
Copy link

weitzj commented Jul 18, 2020

Does this work? I.e if I do not set the annotations at all , I will have an empty block:

annotations:

@weitzj
Copy link

weitzj commented Jul 18, 2020

Related to #107

@inercia
Copy link
Contributor Author

inercia commented Jul 18, 2020

Does this work? I.e if I do not set the annotations at all , I will have an empty block:

annotations:

It should work, as we will always have at least the helm.sh/resource-policy: keep annotation... Once CI is fixed, we will see if this passes it...

@inercia
Keep AES secret
72b2ffa 
Signed-off-by: Alvaro Saurin <[email protected]>
@inercia inercia force-pushed the inercia/keep-aes-secret branch from 3842476 to 72b2ffa Compare July 18, 2020 09:42
@inercia inercia merged commit 518b9ab into master Jul 20, 2020
@inercia inercia deleted the inercia/keep-aes-secret branch July 20, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inercia @weitzj