Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Leverage dbt Semantic Model for the ERD #117

Closed
b-per opened this issue Jul 5, 2024 · 6 comments · Fixed by #122
Closed

[FEAT] Leverage dbt Semantic Model for the ERD #117

b-per opened this issue Jul 5, 2024 · 6 comments · Fixed by #122
Labels
enhancement New feature or request

Comments

@b-per
Copy link

b-per commented Jul 5, 2024

Is your feature request related to a problem? Please describe:

When implementing the new dbt Semantic Layer with metricflow, we have the ability to define entities in our semantic modelling, telling metricflow how to join tables together.

Describe the solution you'd like:

It would be great if dbterd could consume this semantic layer configuration information in order to "discover" how tables relate to each other.

Describe alternatives you've considered:

Manually defining the joins in the models config, on top of having already defined entities

Additional context:

I might be interested in contributing to it if nobody else wants to try to add the feature

@b-per b-per added the triage label Jul 5, 2024
@datnguye datnguye added enhancement New feature or request and removed triage labels Jul 5, 2024
@datnguye
Copy link
Owner

datnguye commented Jul 5, 2024

Thanks @b-per for raising this! I like this idea, definitely it is a great addition to scan the semantic models configs instead of just the relationship tests.

At the moment, I don’t think I have capacity to deliver this feat soon, so marking help_wanted for now, you are more than welcome for creating the PR for this.

Thanks a lot 🙏

@datnguye datnguye added the help wanted Extra attention is needed label Jul 5, 2024
@datnguye
Copy link
Owner

Hi @b-per Do you have any updates on this?
Since I have some availabilities now, I will look into this if you haven't, hence removing help_wanted label.

By the way, do you suggest any sample of dbt jaffle shop with implemented semantic layer, or similar.

Thanks

@b-per
Copy link
Author

b-per commented Jul 27, 2024

Hi!

I haven't worked on it yet, no. This repo is jaffle-shop with metrics and SL configured as well.

@datnguye datnguye removed the help wanted Extra attention is needed label Jul 28, 2024
@datnguye
Copy link
Owner

This should be available in dbterd v1.16 now. See docs.

Keep this issue open to support dbt Cloud.

@b-per
Copy link
Author

b-per commented Aug 12, 2024

Amazing! I will test it in the next few days!

@datnguye
Copy link
Owner

Amazing! I will test it in the next few days!

Thanks, feel free to reopen this issue if you would find any issues 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants