Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add the server start/stop to the main page #19

Open
giventofly opened this issue Dec 9, 2024 · 8 comments
Open

[Enhancement] Add the server start/stop to the main page #19

giventofly opened this issue Dec 9, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@giventofly
Copy link

Can it be added on the main web page?

image

So we can easily restart/stop/start and check the status?

@dave-lang dave-lang self-assigned this Dec 13, 2024
@dave-lang dave-lang added the enhancement New feature or request label Dec 13, 2024
@dave-lang
Copy link
Owner

Which module is that? It looks like 'Servers and Server Status', but that doesn't support restart/stop/start

'Servers and Server Status' provides a simple hook to add more monitor types:
https://github.com/webmin/webmin/blob/46af4889942018832f702d8a4aa14a54bfb34bca/status/status-lib.pl#L239-L264. There's no docs on how this works, but https://github.com/webmin/webmin/blob/master/minecraft/status_monitor.pl provides a good example.

I can add 2 monitor types which should provide some support:

  • Docker Up - This will check the response from docker info to work around the many ways dockerd can be configured
  • Docker Container Up - Check the health of a specific container

Initial support will require the monitor to be added manually

@dave-lang dave-lang linked a pull request Dec 13, 2024 that will close this issue
@dave-lang dave-lang removed a link to a pull request Dec 13, 2024
@giventofly
Copy link
Author

I don't mind adding manually and work as a beta tester for it, just tell me the steps.

and thanks for your time

@dave-lang
Copy link
Owner

To test adding them, install the latest version of this and then go to the 'servers and server status' module under 'tools'. There will be 2 new monitors for docker and docker containers.

@giventofly
Copy link
Author

yes, they appear there but still won't appear in the server status section. My ideas was to save clicking around and have an easy way to check the running dockers.

Essentially it would be this:
image

to appear:

image

with the options to stop/start/restart

@dave-lang
Copy link
Owner

Which module is that? Webmin or virtualmin?

@giventofly
Copy link
Author

It is on the webmin section, so i'm guessing webmin

imagem

@dave-lang
Copy link
Owner

After a bit of research that's actually part of VirtualMin (https://forum.virtualmin.com/t/missing-server-status-webmin-only/123132/9)

If I get time to setup Virtualmin I'll take a look at how those monitors work

@dave-lang dave-lang added improvement Minor improvement to functionality help wanted Extra attention is needed and removed improvement Minor improvement to functionality labels Dec 24, 2024
@giventofly
Copy link
Author

Awesome, it would be a cool improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants