From bf52e331f7e90fd84894e5c6bebd384030b4d336 Mon Sep 17 00:00:00 2001
From: David Allison <62114487+david-allison@users.noreply.github.com>
Date: Sat, 28 Dec 2024 12:15:37 +0000
Subject: [PATCH] docs(libanki): document 'NotetypeJson.req'

This still exists, but is now unused

* reqSize was unused
---
 .../java/com/ichi2/libanki/NotetypeJson.kt    | 40 +++++++++++++++++++
 .../test/java/com/ichi2/libanki/ModelTest.kt  | 11 -----
 2 files changed, 40 insertions(+), 11 deletions(-)

diff --git a/AnkiDroid/src/main/java/com/ichi2/libanki/NotetypeJson.kt b/AnkiDroid/src/main/java/com/ichi2/libanki/NotetypeJson.kt
index deeceed3848a..5addb5c51eef 100644
--- a/AnkiDroid/src/main/java/com/ichi2/libanki/NotetypeJson.kt
+++ b/AnkiDroid/src/main/java/com/ichi2/libanki/NotetypeJson.kt
@@ -138,4 +138,44 @@ class NotetypeJson : JSONObject {
         set(value) {
             put("type", value)
         }
+
+    /**
+     * Defines the requirements for generating cards (for [standard note types][Consts.MODEL_STD])
+     *
+     * A requirement states that either one of, or all of a set of fields must be non-empty to
+     * generate a card using a template. Meaning for a standard note, each template has a
+     * requirement, which generates 0 or 1 cards
+     *
+     * **Example - Basic (optional reversed card):**
+     *
+     * * Fields: `["Front", "Back", "Add Reverse"]`
+     * * `req: [[0, 'any', [0]], [1, 'all', [1, 2]]]`
+     *
+     * meaning:
+     *
+     * * Card 1 needs "Front" to be non-empty
+     * * Card 2 needs both "Back" and "Add Reverse" to be non-empty
+     *
+     * The array is of the form `[T, string, list]`, where:
+     * - `T` is the ordinal of the template.
+     * - `string` is 'none', 'all' or 'any'.
+     * - `list` contains ordinals of fields, in increasing order.
+     *
+     * The output is defined based on the `string`:
+     * - if `"none"'`, no cards are generated for this template. `list` should be empty.
+     * - if `"all"'`, the card is generated if all fields in `list` are non-empty
+     * - if `"any"'`, the card is generated if any field in `list` is non-empty.
+     *
+     * See [The algorithm to decide how to compute req from the template]
+     * (https://github.com/Arthur-Milchior/anki/blob/commented/documentation//templates_generation_rules.md) is explained on:
+     */
+    @Deprecated(
+        "req is no longer used. Exists for backwards compatibility:" +
+            "https://forums.ankiweb.net/t/is-req-still-used-or-present/9977",
+    )
+    var req: JSONArray
+        get() = getJSONArray("req")
+        set(value) {
+            put("req", value)
+        }
 }
diff --git a/AnkiDroid/src/test/java/com/ichi2/libanki/ModelTest.kt b/AnkiDroid/src/test/java/com/ichi2/libanki/ModelTest.kt
index 1a79d5b381c9..5ea1db92f118 100644
--- a/AnkiDroid/src/test/java/com/ichi2/libanki/ModelTest.kt
+++ b/AnkiDroid/src/test/java/com/ichi2/libanki/ModelTest.kt
@@ -16,7 +16,6 @@
 package com.ichi2.libanki
 
 import androidx.test.ext.junit.runners.AndroidJUnit4
-import com.ichi2.libanki.Consts.MODEL_CLOZE
 import com.ichi2.libanki.Utils.stripHTML
 import com.ichi2.libanki.exception.ConfirmModSchemaException
 import com.ichi2.testutils.JvmTest
@@ -505,16 +504,6 @@ class NotetypeTest : JvmTest() {
         )
     }
 
-    private fun reqSize(notetype: NotetypeJson?) {
-        if (notetype!!.getInt("type") == MODEL_CLOZE) {
-            return
-        }
-        assertEquals(
-            notetype.getJSONArray("req").length(),
-            notetype.getJSONArray("tmpls").length(),
-        )
-    }
-
     @Test
     fun nonEmptyFieldTest() {
         val mm = col.notetypes