Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove defaulting of null and undefined to empty string #36

Merged
merged 1 commit into from
May 18, 2018
Merged

remove defaulting of null and undefined to empty string #36

merged 1 commit into from
May 18, 2018

Conversation

davidchambers
Copy link
Owner

Closes #35

Commit message:

This commit changes the algorithm for nested lookups to avoid throwing. The new algorithm distinguishes failed lookups from successful lookups which happen to result in null or undefined:

> format('result: {foo.bar.baz}', null)
'result: '

> format('result: {foo.bar.baz}', {foo: {bar: {baz: null}}})
'result: null'

/cc @RobPethick

@davidchambers
remove defaulting of null and undefined to empty string
d174ab7 
This commit changes the algorithm for nested lookups to avoid throwing.
The new algorithm distinguishes failed lookups from successful lookups
which happen to result in null or undefined:

    > format('result: {foo.bar.baz}', null)
    'result: '

    > format('result: {foo.bar.baz}', {foo: {bar: {baz: null}}})
    'result: null'
@davidchambers davidchambers merged commit 1b1ea4a into master May 18, 2018
@davidchambers davidchambers deleted the lookup branch May 18, 2018 10:11
@JoshWhite JoshWhite mentioned this pull request Jun 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidchambers