From 53607ab1a32228ee22c301308f603e7e3b0bd22a Mon Sep 17 00:00:00 2001
From: Joe Hoyle <joehoyle@gmail.com>
Date: Wed, 21 Sep 2022 16:36:39 +0200
Subject: [PATCH] Support marking methods as abstract

For classes that are registered with `#[php_impl]` this allows functions to be marked as abstract.
---
 crates/macros/src/impl_.rs  | 2 ++
 crates/macros/src/method.rs | 8 ++++++++
 2 files changed, 10 insertions(+)

diff --git a/crates/macros/src/impl_.rs b/crates/macros/src/impl_.rs
index 2fe45df9c5..ca7851baea 100644
--- a/crates/macros/src/impl_.rs
+++ b/crates/macros/src/impl_.rs
@@ -85,6 +85,7 @@ pub enum ParsedAttribute {
     },
     Constructor,
     This,
+    Abstract,
 }
 
 #[derive(Default, Debug, FromMeta)]
@@ -212,6 +213,7 @@ pub fn parse_attribute(attr: &Attribute) -> Result<Option<ParsedAttribute>> {
         "public" => ParsedAttribute::Visibility(Visibility::Public),
         "protected" => ParsedAttribute::Visibility(Visibility::Protected),
         "private" => ParsedAttribute::Visibility(Visibility::Private),
+        "abstract_method" => ParsedAttribute::Abstract,
         "rename" => {
             let ident = if let Meta::List(list) = meta {
                 if let Some(NestedMeta::Lit(lit)) = list.nested.first() {
diff --git a/crates/macros/src/method.rs b/crates/macros/src/method.rs
index d6bbaabc7c..87e12c7c6f 100644
--- a/crates/macros/src/method.rs
+++ b/crates/macros/src/method.rs
@@ -38,6 +38,7 @@ pub struct Method {
     pub optional: Option<String>,
     pub output: Option<(String, bool)>,
     pub _static: bool,
+    pub _abstract: bool,
     pub visibility: Visibility,
 }
 
@@ -81,6 +82,7 @@ pub fn parser(
     let mut visibility = Visibility::Public;
     let mut as_prop = None;
     let mut identifier = None;
+    let mut is_abstract = false;
     let mut is_constructor = false;
     let docs = get_docs(&input.attrs);
 
@@ -90,6 +92,7 @@ pub fn parser(
                 ParsedAttribute::Default(list) => defaults = list,
                 ParsedAttribute::Optional(name) => optional = Some(name),
                 ParsedAttribute::Visibility(vis) => visibility = vis,
+                ParsedAttribute::Abstract => is_abstract = true,
                 ParsedAttribute::Rename(ident) => identifier = Some(ident),
                 ParsedAttribute::Property { prop_name, ty } => {
                     if as_prop.is_some() {
@@ -211,6 +214,7 @@ pub fn parser(
         optional,
         output: get_return_type(struct_ty, &input.sig.output)?,
         _static: matches!(method_type, MethodType::Static),
+        _abstract: is_abstract,
         visibility,
     };
 
@@ -447,6 +451,10 @@ impl Method {
             flags.push(quote! { Static });
         }
 
+        if self._abstract {
+            flags.push(quote! { Abstract });
+        }
+
         flags
             .iter()
             .map(|flag| quote! { ::ext_php_rs::flags::MethodFlags::#flag })