Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Docs and vendored regexes don't work on windows #9

Open
ianlewis opened this issue Aug 28, 2023 · 1 comment
Open

bug: Docs and vendored regexes don't work on windows #9

ianlewis opened this issue Aug 28, 2023 · 1 comment

Comments

@ianlewis
Copy link

Copied from here: ianlewis#1

Regexes in the generated documentation.yml and vendor.yml include *nix path separators which won't match windows paths.

@ianlewis
Copy link
Author

From here: ianlewis#1 (comment)

and it's getting me wondering: is there ever a scenario where path separator is part of the filename passed to linguist? How can I test this actually does anything cause right now it's not ._.

It doesn't seem to be an issue for language detection but for the IsVendored and IsDocumentation functions.

IIUC the regexes generated in the documentation.yml or vendor.yml have a (^|/) prefix which allow them to match a full file path like vendor/package/foo.go or foo.go but this doesn't work in the case of windows paths.

@dayvonjersen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant