DouglasPeuckerLineSimplifier: Avoid crash with Point input and NaN to…

…lerance Fixes libgeos#1078
dbaston · Jun 19, 2024 · 17f63c8 · 17f63c8
1 parent a690eb6
commit 17f63c8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/simplify/DouglasPeuckerLineSimplifier.cpp b/src/simplify/DouglasPeuckerLineSimplifier.cpp
@@ -109,7 +109,7 @@ DouglasPeuckerLineSimplifier::simplifySection(
     std::size_t i,
     std::size_t j)
 {
-    if((i + 1) == j) {
+    if(/*i == j || */(i + 1) == j) {
         return;
     }
 

diff --git a/tests/unit/simplify/DouglasPeuckerSimplifierTest.cpp b/tests/unit/simplify/DouglasPeuckerSimplifierTest.cpp
@@ -334,4 +334,15 @@ void object::test<19>()
         );
 }
 
+// https://github.com/libgeos/geos/issues/1078
+template<>
+template<>
+void object::test<20>()
+{
+    auto gfact = GeometryFactory::getDefaultInstance();
+    auto pt = gfact->createPoint(Coordinate{0,  0});
+    auto result = DouglasPeuckerSimplifier::simplify(pt.get(), std::numeric_limits<double>::quiet_NaN());
+    ensure(result != nullptr);
+}
+
 } // namespace tut