Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proj6 and gdal3 #308

Closed
dbekaert opened this issue May 28, 2021 · 5 comments
Closed

proj6 and gdal3 #308

dbekaert opened this issue May 28, 2021 · 5 comments
Assignees

Comments

@dbekaert
Copy link
Owner

@bbuzz31 @jlmaurer could we check how raider is impacted for this?
isce-framework/isce2#279 (comment)

@jlmaurer
Copy link
Collaborator

@dbekaert RAiDER definitely assumes GDAL3 at the moment and all the syntax assumes this.

@jlmaurer jlmaurer self-assigned this Aug 3, 2021
@dbekaert
Copy link
Owner Author

dbekaert commented Aug 3, 2021

@jlmaurer will add documentation before this can be clsoed

@jlmaurer
Copy link
Collaborator

jlmaurer commented Sep 7, 2021

Our current situation with PROJ, pyproj, and GDAL:

  • Currently GDAL3 is required by the environment file. However, as best I can tell there is no GDAL3-specific code used in the repository. I believe we imposed GDAL3 for the purpose of being able to read and write HDF5/NETCDF files; however, we are not currently using GDAL to read or access those files in the code itself (not including dependencies)
  • I checked the dependencies as well as possible. Rasterio requires GDAL 2.4 or later; geopandas requires Fiona (link to GDAL) and Pyproj but does not specify version dependency for GDAL, pyproj must be >=2.2.
  • Pyproj may be a problem for some users down the line because the latest version requires Python>3.7 and PROJ 7. As long as users are using a conda environment there should be no issue, but other users may have problems.
  • Our current pyproj requirement in the environment is 2.1.0, however this is not consistent with geopandas. We should require >=2.2 so we are consistent across the board and the "always_xy" argument should always get handled correctly.

@jlmaurer
Copy link
Collaborator

jlmaurer commented Sep 7, 2021

#319 addresses the pyproj dependency issue.

@jlmaurer
Copy link
Collaborator

This was actually addressed by #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants