Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] HTTP timeout option #666

Open
garlic-os opened this issue Jul 8, 2024 · 1 comment
Open

[Feature request] HTTP timeout option #666

garlic-os opened this issue Jul 8, 2024 · 1 comment
Labels
enhancement New feature or request urgent

Comments

@garlic-os
Copy link
Contributor

Context/motivation
Certain pieces of crucial funcionality rely on HTTP requests to external APIs. As we who use RAiDER regularly know, sometimes these APIs take a very long time to respond. I think being able to set a maximum amount of time RAiDER waits for an HTTP response could improve user experience and decrease development time.

Feature description
I would like to see an option added to RAiDER's YAML format that allows the user to define the amount of time they are willing to wait for a single HTTP request. My idea for a sensible default would be 30 seconds, or maybe 2 minutes (which is about the amount of time RAiDER waits right now). Speaking optimistically, this may only involve passing a timeout argument to the API calls that make HTTP the requests and adding the option to runtime_group.

@garlic-os garlic-os added the bug Something isn't working label Jul 8, 2024
@jlmaurer jlmaurer added enhancement New feature or request and removed bug Something isn't working labels Jul 13, 2024
@jlmaurer
Copy link
Collaborator

jlmaurer commented Aug 8, 2024

Adding a note on this that HTTP timeouts are causing CircleCI failures, so adding a timeout parameter to all the unit tests (specifically test_downloadGNSS.py is failing right now due to this issue) would help improve unit test reliability.

@jlmaurer jlmaurer added the urgent label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request urgent
Projects
None yet
Development

No branches or pull requests

2 participants