Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] test_processWM.py tests not doing anything #671

Open
garlic-os opened this issue Jul 12, 2024 · 0 comments
Open

[BUG] test_processWM.py tests not doing anything #671

garlic-os opened this issue Jul 12, 2024 · 0 comments
Labels

Comments

@garlic-os
Copy link
Contributor

Describe the bug
Both of the tests in test_processWM.py (test_checkContainment and test_checkContainment2) are set to only do anything if a certain TEST_DIR / 'scenario_1/weather_files/ERA-5_2020_01_03_T23_00_00.nc exists. This file does not exist, however, and so these tests are running without asserting anything.
Maybe I am missing something. Could I be misunderstanding the purpose of these tests?

To Reproduce
Steps to reproduce the behavior:

  1. Pause test_processWM.py::test_checkContainment in the debugger
  2. See the path stored in getWM.files[0] and note that this path does not exist
  3. Observe that the function finishes without ever reaching an assert statement

Expected behavior
These tests should assert something before exiting.

Desktop (please complete the following information):

  • RAiDER git tag:
commit 2b7190cffd4d8f5f9ca57e320675724cb52ec52e (HEAD -> dev, upstream/dev, upstream/HEAD)
Merge: 701d788 25c897a
Author: Jeremy Maurer <[email protected]>
Date:   Thu Jul 11 22:13:41 2024 -0500

    Merge pull request #663 from dbekaert/Changelog
    
    Update CHANGELOG.md
  • OS: Arch Linux 5.15.153.1-microsoft-standard-WSL2 on Windows 10
  • Python v3.12.3
  • conda v24.5.0

Additional context
Add any other context about the problem her

@garlic-os garlic-os added the bug Something isn't working label Jul 12, 2024
@jlmaurer jlmaurer added cleanup and removed bug Something isn't working labels Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants