Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some comments in LOS and ZREF #331

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jlmaurer
Copy link
Collaborator

@jlmaurer jlmaurer commented Dec 2, 2021

Description

  • There is a typo in the losreader.py that states heading angle is degrees CW from north, when ISCE in reality uses CCW from east. The comment has been changed to reflect this convention.
  • Also fixed the default value of zref to reflect what is actually used. This should be addressed later as zref is not currently being used in ZTD calculation

@jlmaurer jlmaurer mentioned this pull request Dec 2, 2021
8 tasks
@jlmaurer jlmaurer requested a review from dbekaert February 22, 2022 21:34
@jlmaurer jlmaurer requested a review from sssangha June 16, 2022 02:55
@jlmaurer
Copy link
Collaborator Author

jlmaurer commented Jun 16, 2022

@sssangha can you verify that the comment change I made in the losreader file is correct? I.e. that the direction is ccw from east, not cw from north.

@jlmaurer
Copy link
Collaborator Author

Pinging @sssangha on this. Thanks!

@dbekaert
Copy link
Owner

@jlmaurer can this be closed?

@jlmaurer
Copy link
Collaborator Author

@dbekaert I'm still not sure which convention for heading is actually correct. The dev branch still says cw from north, but not sure if that is actually the right one. If so then yes can be closed, if not we should just update the comment.

@dbekaert
Copy link
Owner

dbekaert commented Mar 16, 2023

Can we not check isce3 documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants