update dem.py with new dem-stitcher api #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #335 |
|
Closing this as the API was updated to the original (see release 2.1.0 from dem-stitcher). Will issue a new PR to update the funciton name. |
8 tasks
|
@sssangha this is looking good! Can you add the correct version dependency for dem-stitcher to the environment files? I'll try it on a clean install tomorrow then. |
|
@sssangha I'm thinking let's wait to merge this until the conda-forge package is available. We'll move the dependency to the conda install list at the same time then. |
|
@jlmaurer I went ahead and updated to update the latest release of dem-stitcher (i.e. >= 2.3) |
|
@sssangha this should be ready to merge! Can you approve it? Someone else is fine too. :) Thanks, |
garlic-os
added a commit
to garlic-os/RAiDER
that referenced
this pull request
Aug 15, 2022
autopep8 Housekeeping Remove download_only path - Per Jeremy this logic is no longer used. stash dep changes update environment deps correct name of dem_stitcher conda package Merge pull request dbekaert#339 from jlmaurer/fix_stitchdem update dem.py with new dem-stitcher api Merge branch 'dev' into update_deps remove uneeded deps Update ERA5 API Remove unneeded deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dem-stitcher updated their API, which broke RAiDER. This PR fixes that issue. Some issues still remain but will be solved in another PR.
Description
How Has This Been Tested?
Type of change
Checklist: