Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insure data/alaska.geojson.zip is included in package build #604

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

jhkennedy
Copy link
Collaborator

@jhkennedy jhkennedy commented Oct 18, 2023

This fixes the first^ build issue seen in conda-forge/raider-feedstock#11 and conda-forge/raider-feedstock#12.

In both of those PRs, the tools/RAiDER/models/data/alaska.geojson.zip file was not included in the built package because we're building from a src tarball, which does not have the .git data inside it that is used by setuptools_scm to ensure all checked-in files are in the distribution (likewise, this is not an issue seen when building from a clone).

You can reproduce the missing zip file like:

wget https://github.com/dbekaert/RAiDER/archive/v0.4.3.tar.gz 
tar -zxvf v0.4.3.tar.gz
export SETUPTOOLS_SCM_PRETEND_VERSION=0.4.3
python -m pip install ./RAiDER-0.4.3 --no-cache-dir

And look at the installed package.

Then, if you make the changes here, you'll see the zip file show up in the installed package.


^ Takling the second build issue in a follow-on PR

@jhkennedy jhkennedy marked this pull request as ready for review October 19, 2023 02:12
@jhkennedy
Copy link
Collaborator Author

CircleCI appear to be a Herbie problem and not related to this change, so I'm content to punt that to a follow on issue/pr.

Copy link
Collaborator

@jlmaurer jlmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlmaurer jlmaurer merged commit 359d6a3 into dev Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants