From 62c2271a59ee511ad68c3257425029572acfe01c Mon Sep 17 00:00:00 2001 From: Daniel Grigsby Date: Fri, 30 Aug 2019 15:55:34 -0700 Subject: [PATCH] Fix itest on py27 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The itest failure is due to a chain of dependencies that end up trying to install more_itertools without specifying a version. `more_itertools` dropped support for py27 with version 6.0.0, which causes failures when trying to import it in a py27 environment with the same error as here: https://github.com/pytest-dev/pytest/issues/4770 Why did it start failing this week? It looks like our internal pypi: https://pypi.yelpcorp.com/simple/more-itertools/ has only had up to version 4.2.0 recently, and @drmorr uploaded a wheel for v7.2.0 yesterday, which the py27 acceptance test is trying to install. It looks like the old version of pip we’re using, as described in that github issue, is trying to install the latest version of more-itertools, despite itest being marked as only for py3, and failing in the itest. --- requirements-dev.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/requirements-dev.txt b/requirements-dev.txt index c104ec33..fdd6f888 100644 --- a/requirements-dev.txt +++ b/requirements-dev.txt @@ -3,6 +3,7 @@ ipdb==0.10.3 ipython==4.2.0 ipython-genutils==0.1.0 mock +more-itertools==4.2.0 pre-commit==0.8.0 pytest==3.9.3 setuptools==40.0.0