Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts not appearing #44

Closed
edkimmel opened this issue May 17, 2017 · 3 comments
Closed

Charts not appearing #44

edkimmel opened this issue May 17, 2017 · 3 comments
Labels
bug?

Comments

@edkimmel
Copy link

Recently (last few days) charts stopped appearing in the bot responses. The 1d 1m 1y options are there still. The chart option is not turned off.

New posts have a missing chart block.
Existing posts now have a slack image error.

This may be the result of a change in the yahoo finance api.

http://imgur.com/a/vlTSF
@dblock
Copy link
Owner

dblock commented May 17, 2017 •
edited
Loading

Sigh. I'll take a look. Looks like https://chart.finance.yahoo.com is returning errors now. I'm trying to find someone at Yahoo to tell me whether it's permanently dead or not.

@dblock dblock added the bug? label May 17, 2017
@dblock
Copy link
Owner

dblock commented May 22, 2017

Got a confirmation from someone at Yahoo that that API is EOL and won't come back. I replaced Yahoo charts with Google charts for now via 19b8321.

@dblock dblock closed this as completed May 22, 2017
@edkimmel
Copy link
Author

RIP Yahoo charts. Thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug?
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dblock @edkimmel