Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bongo-mpv: bongo calling mpv with badly formed option #61

Open
abhiseck opened this issue Jun 5, 2023 · 0 comments
Open

bongo-mpv: bongo calling mpv with badly formed option #61

abhiseck opened this issue Jun 5, 2023 · 0 comments

Comments

@abhiseck
Copy link

abhiseck commented Jun 5, 2023

I'm using bongo (version 1.1) with mpv backend. My mpv version is: 0.35.1. Trying to play any media with mpv backend would fail with 1 status. I investigated the issue a little and discovered that bongo is calling mpv with:

mpv --input-ipc-server <socket-file> <other-options> <file-name>

but mpv requires that long options be in the following form:
--long-options=value and not int the form --long-option value. So mpv should be called this way:

mpv --input-ipc-server=<socket-file> <other-options> <file-name>

I'd be really greateful if you fix this.

For now here's a quick and dirty fix. Put the following in your init.el:

(defun my-bongo-compose-remote-option (socket-file)
  (list (concat "--input-ipc-server=" socket-file)))

(advice-add 'bongo-compose-remote-option
            :override #'my-bongo-compose-remote-option)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant