From b37524af1f445882e84f6ce03fc0cedb1a82b385 Mon Sep 17 00:00:00 2001
From: Kevin Neville <kevin@neville.se>
Date: Tue, 17 Jan 2023 22:15:49 +0100
Subject: [PATCH] Fix deprecated GitHub action commands (#45)

* Formatting workflows files

* Fix deprecated set-output commands

Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>
---
 .github/workflows/changelog-existence.yml     |  3 +--
 .github/workflows/core-triage.yml             |  5 +---
 .github/workflows/jira-transition-actions.yml |  1 -
 .github/workflows/replace-label.yml           |  5 ++--
 .github/workflows/version-bump.yml            | 24 +++++++++----------
 5 files changed, 16 insertions(+), 22 deletions(-)

diff --git a/.github/workflows/changelog-existence.yml b/.github/workflows/changelog-existence.yml
index 0a947ef4..7367d4ce 100644
--- a/.github/workflows/changelog-existence.yml
+++ b/.github/workflows/changelog-existence.yml
@@ -47,7 +47,6 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-
       - name: "[DEBUG] - Print Inputs"
         shell: bash
         id: echo_inputs
@@ -76,7 +75,7 @@ jobs:
         id: changelog_comment
         with:
           issue-number: ${{ github.event.pull_request.number }}
-          comment-author: 'github-actions[bot]'
+          comment-author: "github-actions[bot]"
           body-includes: ${{ inputs.changelog_comment }}
 
       - name: Set if comment already exists
diff --git a/.github/workflows/core-triage.yml b/.github/workflows/core-triage.yml
index 6f608704..876ca3bb 100644
--- a/.github/workflows/core-triage.yml
+++ b/.github/workflows/core-triage.yml
@@ -14,7 +14,6 @@
 # **when?**
 # Every ~hour, on PR, or manually.
 
-
 name: core-triage
 
 on:
@@ -32,14 +31,13 @@ jobs:
   add-items-to-project:
     runs-on: ubuntu-latest
     steps:
-
       - name: check out repo
         uses: actions/checkout@v2
 
       - name: setup python
         uses: actions/setup-python@v2
         with:
-          python-version: '3.10'
+          python-version: "3.10"
 
       - name: pip installs
         run: pip install -r requirements.txt
@@ -50,4 +48,3 @@ jobs:
         working-directory: scripts/core-triage
         env:
           GH_TOKEN: ${{ secrets.VARIABLE_CORE_TRIAGE_ONLY }}
- 
\ No newline at end of file
diff --git a/.github/workflows/jira-transition-actions.yml b/.github/workflows/jira-transition-actions.yml
index 2ebd81a3..725950e3 100644
--- a/.github/workflows/jira-transition-actions.yml
+++ b/.github/workflows/jira-transition-actions.yml
@@ -27,4 +27,3 @@ jobs:
       JIRA_BASE_URL: ${{ secrets.JIRA_BASE_URL }}
       JIRA_USER_EMAIL: ${{ secrets.JIRA_USER_EMAIL }}
       JIRA_API_TOKEN: ${{ secrets.JIRA_API_TOKEN }}
-
diff --git a/.github/workflows/replace-label.yml b/.github/workflows/replace-label.yml
index ed154f2d..7503e669 100644
--- a/.github/workflows/replace-label.yml
+++ b/.github/workflows/replace-label.yml
@@ -25,7 +25,6 @@
 #     uses: dbt-labs/actions/.github/workflows/triage-labels.yml@main
 #     secrets: inherit
 
-
 name: Replace Issue Label
 
 on:
@@ -49,7 +48,7 @@ defaults:
 permissions:
   issues: write
 
-jobs:      
+jobs:
   triage_label:
     if: contains(github.event.issue.labels.*.name, inputs.original_label)
     runs-on: ubuntu-latest
@@ -62,7 +61,7 @@ jobs:
           echo "all variables defined as inputs"
           echo "original_label:    ${{ inputs.original_label }}"
           echo "new_label:         ${{ inputs.new_label }}"
-  
+
       - name: switch labels
         id: switch_labels
         run: |
diff --git a/.github/workflows/version-bump.yml b/.github/workflows/version-bump.yml
index 54f6661e..cfb0990c 100644
--- a/.github/workflows/version-bump.yml
+++ b/.github/workflows/version-bump.yml
@@ -17,9 +17,9 @@ on:
   workflow_call:
     inputs:
       version_number:
-       description: 'The version number to bump to (ex. 1.2.0, 1.3.0b1)'
-       type: string
-       required: true
+        description: "The version number to bump to (ex. 1.2.0, 1.3.0b1)"
+        type: string
+        required: true
 
 jobs:
   bump:
@@ -67,7 +67,7 @@ jobs:
       - name: Set branch value
         id: variables
         run: |
-          echo "::set-output name=BRANCH_NAME::prep-release/${{ github.event.inputs.version_number }}_$GITHUB_RUN_ID"
+          echo "BRANCH_NAME=prep-release/${{ github.event.inputs.version_number }}_$GITHUB_RUN_ID" >> $GITHUB_OUTPUT
 
       - name: Create PR branch
         run: |
@@ -110,18 +110,18 @@ jobs:
       - name: Commit version bump to branch
         uses: EndBug/add-and-commit@v7
         with:
-          author_name: 'Github Build Bot'
-          author_email: 'buildbot@fishtownanalytics.com'
-          message: 'Bumping version to ${{ github.event.inputs.version_number }} and generate CHANGELOG'
-          branch: '${{ steps.variables.outputs.BRANCH_NAME }}'
-          push: 'origin origin/${{ steps.variables.outputs.BRANCH_NAME }}'
+          author_name: "Github Build Bot"
+          author_email: "buildbot@fishtownanalytics.com"
+          message: "Bumping version to ${{ github.event.inputs.version_number }} and generate CHANGELOG"
+          branch: "${{ steps.variables.outputs.BRANCH_NAME }}"
+          push: "origin origin/${{ steps.variables.outputs.BRANCH_NAME }}"
 
       - name: Create Pull Request
         uses: peter-evans/create-pull-request@v3
         with:
-          author: 'Github Build Bot <buildbot@fishtownanalytics.com>'
+          author: "Github Build Bot <buildbot@fishtownanalytics.com>"
           base: ${{github.ref}}
-          title: 'Bumping version to ${{ github.event.inputs.version_number }} and generate changelog'
-          branch: '${{ steps.variables.outputs.BRANCH_NAME }}'
+          title: "Bumping version to ${{ github.event.inputs.version_number }} and generate changelog"
+          branch: "${{ steps.variables.outputs.BRANCH_NAME }}"
           labels: |
             Skip Changelog