Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1640] Remove custom code to poll status for python model jobs on cluster #422

Closed
ChenyuLInx opened this issue Dec 10, 2022 · 0 comments · Fixed by #423
Closed

[CT-1640] Remove custom code to poll status for python model jobs on cluster #422

ChenyuLInx opened this issue Dec 10, 2022 · 0 comments · Fixed by #423

Comments

@ChenyuLInx
Copy link
Contributor

ChenyuLInx commented Dec 10, 2022

We added

def _wait_operation(self, operation):
# can't use due to https://github.com/googleapis/python-api-core/issues/458
# response = operation.result(retry=self.retry)
# Temp solution to wait for the job to finish
start = time.time()
while not operation.done(retry=None) and time.time() - start < self.timeout:
time.sleep(OPERATION_RETRY_TIME)

due to issue googleapis/python-api-core#458 (comment). Remove this and use method provided by operation directly

@github-actions github-actions bot changed the title Remove custom code to poll status for python model jobs on cluster [CT-1640] Remove custom code to poll status for python model jobs on cluster Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant