Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fire_event_if_test #66

Closed
1 task done
emmyoop opened this issue Feb 6, 2024 · 1 comment · Fixed by #65
Closed
1 task done

Remove fire_event_if_test #66

emmyoop opened this issue Feb 6, 2024 · 1 comment · Fixed by #65
Assignees
@emmyoop

Comments

@emmyoop
Copy link
Member

emmyoop commented Feb 6, 2024

Housekeeping

  • I am a maintainer of dbt-common

Short description

Remove fire_event_if_test since we no longer need it.

Acceptance criteria

  • fire_event_if_test is gone

Suggested Tests

Verify

  • dbt-core integration tests (this is automated now)
  • dbt-adapters integrations tests
  • do we need to check adapters too?

Impact to Other Teams

Possibly adapters if they use fire_event_if_test

Will backports be required?

No

Context

This function is only used for log lines in tests that end up cluttering the output is pytest is installed.
@emmyoop emmyoop mentioned this issue Feb 6, 2024
Merged
5 tasks
@emmyoop emmyoop self-assigned this Feb 7, 2024
@emmyoop
Copy link
Member Author

emmyoop commented Feb 7, 2024

I verified that this is not used in 1p adapters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emmyoop emmyoop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove fire_event_if_test dbt-labs/dbt-common
1 participant
@emmyoop