Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial parsing: do minimal validation on schema file content #3426

Closed
gshank opened this issue Jun 3, 2021 · 1 comment
Closed

Partial parsing: do minimal validation on schema file content #3426

gshank opened this issue Jun 3, 2021 · 1 comment
Assignees

Comments

@gshank
Copy link
Contributor

gshank commented Jun 3, 2021

The partial parsing manipulation of schema file dictionaries (derived from yaml) depend on a few things being correct, such as the top level keys ('models', 'seeds', etc) having values that are lists, that the lists contain dictionaries, and the dictionaries have a 'name' key. If these condition are not correct the errors will not be clear or helpful ('key error', etc).

We should do some minimal validation on new schema file content to verify that the above conditions are true. (More specific validation is done in the schema parser itself.)

@jtcohen6
Copy link
Contributor

Resolved by #3460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants