-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-651] Custom merge behavior for configs #4108
Comments
What about:
Using this syntax generally would allow some pretty powerful patterns and seems like it would cover most use cases. |
We've made an initial experimental attempt at this in #5230 for the What would it look like to extend that for other configs? The default behavior needs to remain, for backwards compatibility. We should do our best to give a reasonable default per config type. In the case of
But then we might also support:
version: 2
models:
- name: my_model
config:
tags: default_behavior
# or maybe this
tags: '+add_this_one'
# or this
tags: '-remove_this_one'
# or this
tags:
- '+add_this_one'
- '-remove_this_one' I'm not sure of the right way to enable "clobber" for a config that's additive by default. Definitely open to ideas here. Some kind of "remove all tags via wildcard operator?":
Given this capability going forward, I think we'd be more inclined to support clobbering by default for new configs. |
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days. |
Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest; add a comment to notify the maintainers. |
See: #3326, #3816, #4105
Most configs today, when defined, will clobber less-specific inherited values. Some configs have different merge behavior, however:
tags
are appendedmeta
is merged/updatedpre-hook
+post-hook
are additive, and functional... I appreciate that these are quite similar to indexes; I'm not sure if I'd make the same decision today!Sometimes, it's desirable to clobber
tags
or pre/post hooks. Sometimes, it's desirable to append/merge custom configs that are clobber-only.We need to figure out:
MergeBehavior
for arbitrary configsPossible syntax
Just some ideas we've played with:
The text was updated successfully, but these errors were encountered: