Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-75] [Feature] Per-query retry strategy for all adapters (currently available only for BigQuery) #4598

Closed
1 task done
jvenezia opened this issue Jan 20, 2022 · 1 comment
Assignees
Labels
duplicate This issue or pull request already exists enhancement New feature or request Team:Adapters Issues designated for the adapter area of the code

Comments

@jvenezia
Copy link

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Currently only the BigQuery adapter has a retry option on the query-level: https://docs.getdbt.com/reference/warehouse-profiles/bigquery-profile#retries

This would be very useful to have in other adapter.
I am particularly interested in Redshift but I think it could be useful to have globally implemented (not specific for an adapter) in dbt.

Describe alternatives you've considered

Isolate the models that needs retries and use our own retry methods (Airflow or custom...).

Who will this benefit?

All dbt users, especially with large code bases with many concurrent runs which I believe increases the change to have unexpected errors (could not open relation with OID 123...).

Are you interested in contributing this feature?

I can't unfortunately.

Anything else?

No response

@jvenezia jvenezia added enhancement New feature or request triage labels Jan 20, 2022
@github-actions github-actions bot changed the title [Feature] Per-query retry strategy for all adapters (currently available only for BigQuery) [CT-75] [Feature] Per-query retry strategy for all adapters (currently available only for BigQuery) Jan 20, 2022
@jtcohen6 jtcohen6 added the Team:Adapters Issues designated for the adapter area of the code label Jan 20, 2022
@nathaniel-may nathaniel-may self-assigned this Jan 25, 2022
@nathaniel-may
Copy link
Contributor

Hi, @jvenezia! Thanks for the feature request. The BigQuery adapter has the best support for retries because BigQuery provides it via their API and we just pass along the configured value. Today, the Spark and Snowflake adapters each have much more rudimentary adapter-side implementations so something similar is likely possible for the remaining adapters as well.

For Redshift specifically, there is already another open issue: #3303. Please feel free to join the conversation over there. In the interest of keeping the conversation streamlined I'm closing this issue as a duplicate.

@nathaniel-may nathaniel-may added duplicate This issue or pull request already exists and removed triage labels Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request Team:Adapters Issues designated for the adapter area of the code
Projects
None yet
Development

No branches or pull requests

3 participants