[CT-1048] As part of proto integration convert NodeFinished class and run_results to use proto definitions

[gshank]

The proto events will need to be generated outside of our normal class hierarchy. We need to establish best practices and methods for doing this easily, since we'll need node output for all of our node types. In addition we need proto definitions for RunResults.

As part of this effort we will collect requirements from other stakeholders to use when choosing which information to include and to plan additional events.

[leahwicz]

@gshank could you edit this ticket to better describe what we talked about

[gshank]

Will identify a list of existing events that would be most useful for updating the progress of execution and parsing, and if there are gaps, create new events. In addition will create logging events that will contain some of the information that is currently retrieved from run_result.json.

[gshank]

A related part of this is identifying ways to generate proto definitions from Python classes, because creating a set of parallel classes where every time we add a new attribute it must be added in two places is suboptimal. This might look like adding proto integer identifiers to attributes, like pure_protobuf.

[jtcohen6]

Split the spike/investigation into a new ticket: #5987

Let's keep this ticket focused on:

• the info from NodeFinished that can support the end-to-end Model Timing MVP with Metadata
• identifying gaps in the logs, vis-a-vis what Metadata/IDE need — e.g. decorating more events with NodeInfo

[gshank]

@jtcohen6 Question: We have 22 logging events that include node_info right now. But a lot of them are variants such as "PrintModelResultLine" and "PrintModelErrorResultLine". These events match the stdout lines that we produce in a terminal. But a consumer of the logs is going to have to subscribe to multiple events for every one of the node types in order to capture both success and failure.

I'm wondering if it might not work better to have a single "ModelResult", which contains a success attribute, and can produce either the success or error message.

[emmyoop]

This has been done as part other tickets.