Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1499] Fix f-string in CacheMiss message #6241

Closed
jtcohen6 opened this issue Nov 13, 2022 · 0 comments · Fixed by #6243
Closed

[CT-1499] Fix f-string in CacheMiss message #6241

jtcohen6 opened this issue Nov 13, 2022 · 0 comments · Fixed by #6243
Labels
adapter_caching Issues related to the adapter's relation cache bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors! logging

Comments

@jtcohen6
Copy link
Contributor

It looks like there's an extra set of quotes in the message for CacheMiss, such that it always prints out as:

On "macro_my_macro": cache miss for schema "{self.database}.{self.schema}", this is inefficient

I think this:

def message(self) -> str:
return (
f'On "{self.conn_name}": cache miss for schema '
'"{self.database}.{self.schema}", this is inefficient'
)

Is just missing an important letter f:

 def message(self) -> str: 
     return ( 
         f'On "{self.conn_name}": cache miss for schema ' 
         f'"{self.database}.{self.schema}", this is inefficient' 
     )
On "macro_my_macro": cache miss for schema "jerco.dbt_jcohen", this is inefficient
@jtcohen6 jtcohen6 added bug Something isn't working Team:Language logging labels Nov 13, 2022
@github-actions github-actions bot changed the title Fix f-string in CacheMiss message [CT-1499] Fix f-string in CacheMiss message Nov 13, 2022
@jtcohen6 jtcohen6 added the adapter_caching Issues related to the adapter's relation cache label Dec 7, 2022
@jtcohen6 jtcohen6 added the good_first_issue Straightforward + self-contained changes, good for new contributors! label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapter_caching Issues related to the adapter's relation cache bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors! logging
Projects
None yet
1 participant