Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2587] DelayedFileHandler is Obsolete, Should Be Removed in 1.5 and Later Versions #7679

Closed
peterallenwebb opened this issue May 22, 2023 · 1 comment · Fixed by #7683
Closed
Assignees
Labels
logging tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@peterallenwebb
Copy link
Contributor

peterallenwebb commented May 22, 2023

The DelayedFileHandler is a class in Core's legacy Logbook logging system which captured log lines fired before log file initialization and buffered them to be written when the log file was created. Since version 1.5.0, Core no longer fires events between these two points in time. Furthermore, because the new Click-based API no longer makes a separate call to set a file path for the legacy logger, the buffer is never flushed and sometimes overflows when legacy logging is used (e.g. by dbt-cloud).

Since DelayedFileHandler no longer serves a useful purpose, and it is causing expensive errors, we will simply remove it in 1.5.1rc2+.

@github-actions github-actions bot changed the title DelayedFileHandler is Obsolete, Should Be Removed in 1.5 and Later Versions [CT-2587] DelayedFileHandler is Obsolete, Should Be Removed in 1.5 and Later Versions May 22, 2023
@peterallenwebb peterallenwebb self-assigned this May 22, 2023
@peterallenwebb
Copy link
Contributor Author

Change in main is done, I am now preparing the backport to 1.5.latest, which @ChenyuLInx has suggested we test with dbt-rpc to ensure no breaking changes.

@jtcohen6 jtcohen6 added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality logging and removed triage labels Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants